fix(i18n): middleware should consider trailing slash when redirecting#9085
Merged
fix(i18n): middleware should consider trailing slash when redirecting#9085
Conversation
🦋 Changeset detectedLatest commit: aba6476 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
71f7247 to
e394a31
Compare
e394a31 to
aba6476
Compare
matthewp
approved these changes
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes a bug where when
trailingSlashisalways, the middleware should take that into consideration and redirect to the correct URL.To do so, I had to add
trailingSlashto the manifest. This is a piece of information that so far was saved insiderouteData._meta, although this is now required to have inside the SSR manifest, at the top level.Testing
I created new test cases, for each pipeline
Docs
N/A