Skip to content

fix(assets): Only use src to hash files generated by the passthrough service#9075

Merged
Princesseuh merged 3 commits intomainfrom
fix/passthrough-hashing
Nov 13, 2023
Merged

fix(assets): Only use src to hash files generated by the passthrough service#9075
Princesseuh merged 3 commits intomainfrom
fix/passthrough-hashing

Conversation

@Princesseuh
Copy link
Copy Markdown
Member

Changes

Only uses the src to hash images on the passthrough service, that way attributes don't cause multiple files to be generated.

Fix #9002

Testing

We have tests that are testing this hook of the image service API

Docs

N/A

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 12, 2023

🦋 Changeset detected

Latest commit: 0a65787

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 12, 2023
@bluwy
Copy link
Copy Markdown
Member

bluwy commented Nov 13, 2023

Looks like we also need a changeset before merging this

@github-actions github-actions bot added the pr: docs A PR that includes documentation for review label Nov 13, 2023
@Princesseuh Princesseuh merged commit c5dc8f2 into main Nov 13, 2023
@Princesseuh Princesseuh deleted the fix/passthrough-hashing branch November 13, 2023 09:58
@astrobot-houston astrobot-houston mentioned this pull request Nov 13, 2023
natemoo-re pushed a commit that referenced this pull request Nov 22, 2023
…service (#9075)

* fix(assets): Only use src to hash files generated by the passthrough service

* chore: changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

passthroughImageService shouldn't output multiple files

2 participants