fix(logger): namespace label in debug logger#9067
Merged
bluwy merged 4 commits intowithastro:mainfrom Nov 13, 2023
danielhajduk:fix/logger
Merged
fix(logger): namespace label in debug logger#9067bluwy merged 4 commits intowithastro:mainfrom danielhajduk:fix/logger
bluwy merged 4 commits intowithastro:mainfrom
danielhajduk:fix/logger
Conversation
🦋 Changeset detectedLatest commit: a09ba30 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bluwy
approved these changes
Nov 13, 2023
bluwy
reviewed
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
this.optionsargument is not needed indebugfunction (see below). Passing it as a first argument causes[object Object]in the namespace label as described in the issueastro/packages/astro/src/core/logger/node.ts
Lines 110 to 114 in 13ca6d9
Testing
Tested via
pnpm --filter @example/minimal run build --verboseDocs
-