Skip to content

feat(overlay): Add a settings panel#9058

Merged
Princesseuh merged 8 commits intomainfrom
feat/overlay-settings
Nov 13, 2023
Merged

feat(overlay): Add a settings panel#9058
Princesseuh merged 8 commits intomainfrom
feat/overlay-settings

Conversation

@Princesseuh
Copy link
Copy Markdown
Member

@Princesseuh Princesseuh commented Nov 10, 2023

Changes

Add a little settings panel guy and the components it needs (the toggle)
image

Those options are saved locally, using localStorage and are intended for Dev Overlay settings.

Testing

Added a test that it opens and closes, like other plugins

Docs

Will do docs

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 10, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: bacda87

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Nov 10, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 10, 2023 •
edited
Loading

⚖️ Bundle Size Check

Latest commit: bacda87

File Old Size New Size Change
dev-overlay/entrypoint 47.93 KB 47.93 KB 0 B
dev-overlay/overlay 24.23 KB 24.23 KB 0 B
dev-overlay/plugins/astro 2.26 KB 2.26 KB 0 B
dev-overlay/plugins/settings 2.74 KB 2.74 KB 0 B
dev-overlay/plugins/utils/window 932 B 932 B 0 B
dev-overlay/settings 326 B 326 B 0 B
dev-overlay/ui-library/icons 13.83 KB 13.83 KB 0 B
dev-overlay/ui-library/toggle 1.21 KB 1.21 KB 0 B
dev-overlay/ui-library/window 16.41 KB 16.41 KB 0 B

@Princesseuh Princesseuh mentioned this pull request Nov 10, 2023
Merged
bluwy
bluwy approved these changes Nov 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@bluwy bluwy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We'd need a changeset before merging this.

I have a few thoughts about the design/behaviour, but not blocking the PR:

  1. When opening the first Astro panel, then the settings panel, should the Astro panel auto-close? So there's only one panel at a time.
  2. The settings name e.g. Verbose logging? feels a bit weird with the ?. I don't usually see trailing punctuations in settings names.
  3. Each setting controls, the setting description is larger than the setting title. Is it intentional?
image

EDIT: The above image is what I see locally in Safari and Chrome, which seems to be slightly different compared to your screenshot.

@Princesseuh
Copy link
Copy Markdown
Member Author

Princesseuh commented Nov 13, 2023 •
edited
Loading

  1. Each setting controls, the setting description is larger than the setting title. Is it intentional?
image EDIT: The above image is what I see locally in Safari and Chrome, which seems to be slightly different compared to your screenshot.

That's weird, I can't see this no matter what browser I use 🤔

When opening the first Astro panel, then the settings panel, should the Astro panel auto-close? So there's only one panel at a time.

This is planned!

@Princesseuh Princesseuh merged commit 5ef89ef into main Nov 13, 2023
@Princesseuh Princesseuh deleted the feat/overlay-settings branch November 13, 2023 12:09
@astrobot-houston astrobot-houston mentioned this pull request Nov 13, 2023
Merged
@bluwy
Copy link
Copy Markdown
Member

bluwy commented Nov 13, 2023

That's weird, I can't see this no matter what browser I use 🤔

Strange, I can't reproduce this anymore. Sorry for the false alarm 😅

natemoo-re pushed a commit that referenced this pull request Nov 22, 2023
@Princesseuh @natemoo-re
feat(overlay): Add a settings panel (#9058)
a39d670
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bluwy bluwy bluwy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Princesseuh @bluwy