Skip to content

Fix Lit integration hydration ordering#9018

Merged
matthewp merged 2 commits intowithastro:mainfrom
augustjk:fix-lit-hydration
Nov 8, 2023
Merged

Fix Lit integration hydration ordering#9018
matthewp merged 2 commits intowithastro:mainfrom
augustjk:fix-lit-hydration

Conversation

@augustjk
Copy link
Copy Markdown
Contributor

@augustjk augustjk commented Nov 7, 2023

Changes

Testing

Added an extra assertion in nested component test that looks for defer-hydration attribute on the child element.

Docs

Bug fix only. No change in docs necessary.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 7, 2023

🦋 Changeset detected

Latest commit: 00174c9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: lit Related to Lit (scope) pkg: integration Related to any renderer integration (scope) pr: docs A PR that includes documentation for review labels Nov 7, 2023
@matthewp
Copy link
Copy Markdown
Contributor

matthewp commented Nov 8, 2023

Thanks so much!

@matthewp matthewp merged commit 23c9a30 into withastro:main Nov 8, 2023
@astrobot-houston astrobot-houston mentioned this pull request Nov 8, 2023
natemoo-re pushed a commit that referenced this pull request Nov 22, 2023
* Provide renderer instance to `customElementHostStack`

* Add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: integration Related to any renderer integration (scope) pkg: lit Related to Lit (scope) pr: docs A PR that includes documentation for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lit integration hydration occurs in incorrect order for nested components

2 participants