Use jpeg source files as fallback rather than converting to png#9010
Use jpeg source files as fallback rather than converting to png#9010Princesseuh merged 6 commits intomainfrom
Conversation
If JPEG is the source for an image, it is likely that was the intention of the creator of the image - PNGs are more effective at compressing simple shapes with lossless quality, while JPEGs are more effective at providing high-noise images like photographs in an effective file size. (https://web.dev/articles/choose-the-right-image-format#features_of_different_raster_image_formats)
|
Not sure about this. I personally don't mind about what the input is, but I want the most optimized output (webp if possible). Can this behavior be updated through the config instead of making it the default? |
This is not a change removing webp, it is a change enforcing There will still always be a |
🦋 Changeset detectedLatest commit: fbcc04d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Oh ok! I misunderstood, thanks for clarifying! |
Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com>
Princesseuh
left a comment
There was a problem hiding this comment.
Looks great to me! Will merge on merge day tomorrow.
Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com>
Changes
.jpgand.jpegas image sources that will be represented as themselves inPicture.astroIf JPEG is the source for an image, it is likely that was the intention of the creator of the image - PNGs are more effective at compressing simple shapes with lossless quality, while JPEGs are more effective at providing high-noise images like photographs in an effective file size. (https://web.dev/articles/choose-the-right-image-format#features_of_different_raster_image_formats)
Testing
This is a change in default behavior of an existing api
Docs
/cc @withastro/maintainers-docs for feedback!
Probably worth updating the docs with the defaults?