refactor(i18n): compute preferred locales lazily#8997
Merged
ematipico merged 3 commits intofeat/i18n-routingfrom Nov 6, 2023
Merged
refactor(i18n): compute preferred locales lazily#8997ematipico merged 3 commits intofeat/i18n-routingfrom
ematipico merged 3 commits intofeat/i18n-routingfrom
Conversation
|
matthewp
reviewed
Nov 3, 2023
bluwy
approved these changes
Nov 6, 2023
ematipico
added a commit
that referenced
this pull request
Nov 6, 2023
ematipico
added a commit
that referenced
this pull request
Nov 6, 2023
ematipico
added a commit
that referenced
this pull request
Nov 7, 2023
ematipico
added a commit
that referenced
this pull request
Nov 8, 2023
ematipico
added a commit
that referenced
this pull request
Nov 8, 2023
ematipico
added a commit
that referenced
this pull request
Nov 8, 2023
ematipico
added a commit
that referenced
this pull request
Nov 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
From the API bash session, a suggestion was to compute
preferredLocaleandpreferredLocaleListlazily. To do so, we agreed thati18n.localescab be passed down to the point where we compute the context for the endpoints, and theAstrofaux-global.This PR does that by removing the computation of
preferredLocaleandpreferredLocaleListfrom the three pipelines, and instead, we simply passlocales. The computation is moved inside two new getters.Testing
This is a refactor, so existing functionality should not change and the existing tests should still pass.
Docs
N/A