feat(assets): Delete original assets unused outside of the optimization pipeline#8954
Merged
Princesseuh merged 8 commits intomainfrom Nov 8, 2023
Merged
feat(assets): Delete original assets unused outside of the optimization pipeline#8954Princesseuh merged 8 commits intomainfrom
Princesseuh merged 8 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 023be5d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
natemoo-re
approved these changes
Oct 30, 2023
Member
natemoo-re
left a comment
There was a problem hiding this comment.
LGTM! Very nice use of Proxy. You could get rid of the // @ts-expect-error but it's not a huge deal.
sarah11918
reviewed
Nov 6, 2023
Member
sarah11918
left a comment
There was a problem hiding this comment.
Just turned this into something that could go in the blog post!
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Merged
natemoo-re
pushed a commit
that referenced
this pull request
Nov 22, 2023
…on pipeline (#8954) Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
What the title says. On the technical level, this works by making images Proxies, whenever any property of an image is referred to directly we add the image to a list of images to not delete.
Fix #8143
Testing
Tests should pass!
Docs
N/A, we didn't document that they stayed there before.