Conversation
🦋 Changeset detectedLatest commit: 7d47004 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
!preview integration-middleware |
Contributor
|
Contributor
Author
|
This can be tried out with: npm install astro@next--integration-middlewareNote that preview releases are temporary and are only intended to test out a feature. |
852ac0f to
b68d770
Compare
natemoo-re
reviewed
Nov 1, 2023
Comment on lines
+140
to
+144
| if(typeof updatedSettings.middleware[order] === 'undefined') { | ||
| throw new Error( | ||
| `The "${integration.name}" integration is trying to add middleware but did not specify an order.` | ||
| ); | ||
| } |
Member
There was a problem hiding this comment.
I'm not sure what default makes the most sense, but I wouldn't expect to be required to provide order. For example, a middleware that adds a new route could really go anywhere.
Contributor
Author
There was a problem hiding this comment.
Hm, I don't like having a default when it's not obvious what the default should be. It really depends on the use-case; if you are doing something that modifies the response you want to be in pre, if you are adding locals then post is fine.
Member
There was a problem hiding this comment.
I agree with Matthew on this one. Since the order is essential and we can't guess what the user intends to do, I think we need to force the user to choose.
ematipico
reviewed
Nov 2, 2023
Comment on lines
+140
to
+144
| if(typeof updatedSettings.middleware[order] === 'undefined') { | ||
| throw new Error( | ||
| `The "${integration.name}" integration is trying to add middleware but did not specify an order.` | ||
| ); | ||
| } |
Member
There was a problem hiding this comment.
I agree with Matthew on this one. Since the order is essential and we can't guess what the user intends to do, I think we need to force the user to choose.
bluwy
reviewed
Nov 3, 2023
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
sarah11918
reviewed
Nov 6, 2023
Member
sarah11918
left a comment
There was a problem hiding this comment.
Looks great @matthewp ! Just left some comments on the changeset!
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
sarah11918
reviewed
Nov 6, 2023
ematipico
approved these changes
Nov 6, 2023
Member
ematipico
left a comment
There was a problem hiding this comment.
Looks good. I'm really looking forward to having this feature shipped!
bluwy
approved these changes
Nov 7, 2023
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
sarah11918
approved these changes
Nov 8, 2023
Merged
natemoo-re
pushed a commit
that referenced
this pull request
Nov 22, 2023
* Rebase * Use an empty module if there is no real middleware * Add debug logging * Use normalizePath * Add a better example in the changesetp * Update .changeset/khaki-glasses-raise.md Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com> * Update .changeset/khaki-glasses-raise.md Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com> * Update .changeset/khaki-glasses-raise.md Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> * Update .changeset/khaki-glasses-raise.md Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> * Update .changeset/khaki-glasses-raise.md Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> * Update .changeset/khaki-glasses-raise.md Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> * Update packages/astro/src/core/middleware/vite-plugin.ts Co-authored-by: Emanuele Stoppa <my.burning@gmail.com> * Review comments * oops * Update .changeset/khaki-glasses-raise.md Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com> --------- Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com> Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Docs