Switch build.inlineStylesheets default to auto#8118
Switch build.inlineStylesheets default to auto#8118ematipico merged 8 commits intowithastro:nextfrom
build.inlineStylesheets default to auto#8118Conversation
🦋 Changeset detectedLatest commit: b37af2c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Ready for review |
|
Note from docs: there will also need to be a corresponding update to the configuration-reference page via |
|
Forgot about it, thanks a lot for the reminder! |
| * { | ||
| * build: { | ||
| * inlineStylesheets: `auto`, | ||
| * inlineStylesheets: `never`, |
There was a problem hiding this comment.
Heads up that I also updated here, since we typically show a setting that would need to be set, and you wouldn't need to set auto specifically now that it's the default.
|
|
I'm not sure about either of these because I'm not familiar with the implications of merging into next. Would the changeset become part of 3.0 release notes? Is there a |
|
I would probably not approve this until the docs are updated. I can grab those tomorrow. |
| 'astro': patch | ||
| --- | ||
|
|
||
| Astro is smarter about CSS! Small stylesheets are now inlined by default, and no longer incur the cost of additional requests to your server. Your visitors will have to wait less before they see your pages, especially those in remote locations or in a subway. |
There was a problem hiding this comment.
lol How can I not approve this?
sarah11918
left a comment
There was a problem hiding this comment.
Docs is happy! Have also reviewed the corresponding docs PR, so we're all in good shape! 🙌
* switch inlineStylesheets default * use previous default for astro/test * use previous default for content-collections-render.test.js * integrations: node, deno, mdx, markdown * typedocs: switch inlineStylesheets default * Update example to show non-default * add changeset * reword changeset --------- Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
* switch inlineStylesheets default * use previous default for astro/test * use previous default for content-collections-render.test.js * integrations: node, deno, mdx, markdown * typedocs: switch inlineStylesheets default * Update example to show non-default * add changeset * reword changeset --------- Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Changes
Testing
inlineStylesheets: neverfor tests that were written when it was the defaultDocs
The
Bundle controlsection will need to be updated.PR: withastro/docs#4253 (live, updated)