Skip to content

Make Astro.cookies.get(key) return undefined#7888

Merged
ematipico merged 1 commit intonextfrom
cookies-get
Aug 1, 2023
Merged

Make Astro.cookies.get(key) return undefined#7888
ematipico merged 1 commit intonextfrom
cookies-get

Conversation

@matthewp
Copy link
Copy Markdown
Contributor

Changes

  • Astro.cookies.get(key) now returns undefined if the cookie isn't present.
  • This is a breaking change, as previously you needed to use has() to check for existence.

Testing

  • Test updated

Docs

  • TBD

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 31, 2023

🦋 Changeset detected

Latest commit: 9661906

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 31, 2023
Copy link
Copy Markdown
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a nice change!

Copy link
Copy Markdown
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branch must be rebased again, blocking to be safe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants