Conversation
🦋 Changeset detectedLatest commit: 728d4e7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6f0715f to
48c1146
Compare
bluwy
reviewed
Jul 26, 2023
Member
bluwy
left a comment
There was a problem hiding this comment.
The general validation logic looks great! Got some questions/comments about some things
48c1146 to
83d15dd
Compare
321d44d to
71ad64b
Compare
Contributor
|
Should the values be lower-case? When we have string flags like this elsewhere in the code I'm pretty sure they are lower-case. |
5fc1afc to
4b3085e
Compare
Member
Author
|
@matthewp that's addressed now, thank you |
bluwy
reviewed
Jul 27, 2023
7049810 to
2a84125
Compare
a606b49 to
f520318
Compare
bluwy
approved these changes
Jul 28, 2023
ematipico
added a commit
that referenced
this pull request
Jul 31, 2023
ematipico
added a commit
that referenced
this pull request
Aug 1, 2023
ematipico
added a commit
that referenced
this pull request
Aug 1, 2023
ematipico
added a commit
that referenced
this pull request
Aug 3, 2023
ematipico
added a commit
that referenced
this pull request
Aug 8, 2023
ematipico
added a commit
that referenced
this pull request
Feb 5, 2025
ematipico
added a commit
that referenced
this pull request
Feb 5, 2025
ematipico
added a commit
that referenced
this pull request
Feb 6, 2025
ematipico
added a commit
that referenced
this pull request
Feb 6, 2025
ematipico
added a commit
that referenced
this pull request
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Introducing Astro features. Astro features are features that astro has out the box, and sometimes users can opt-in.
Few examples:
staticOutputif a user uses a specific adapter, the adapter needs to be able to serve those static assets. An example is Cloudflare, which doesn't support it.assets: not supported by those adapters that are incompatible with nodeThis PR adds a new API that adapters can use when registering one. It's called
supportedFeatures, and it's a new way to tell Astro if and when an adapter is able to support certain features that are enabled via configuration.The adapter can also tell Astro the kind of support:
For now, this new API/object is not mandatory, but it will be in Astro 4.0.
The PR also updates the adapters that we maintain, and it adds the feature map to them.
About
assetsThere's a small caveat for the assets. Astro assets is a feature that is already turned on by default, meaning that Astro sets already a default service. This means that adapters that don't support assets will always get an error, which is inconvenient. I came up with a solution where we set the default after the adapter validation, although I don't like the solution very much, and I wonder if there's a better way to handle a case like this.
The assets feature is just an example; we might have the same problem with future features like this. What do you suggest?
Testing
I added new unit test cases and updated the existing ones.
Docs
I will create the changelog in another PR