Conversation
🦋 Changeset detectedLatest commit: cd06296 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ematipico
commented
May 26, 2023
ematipico
commented
May 26, 2023
ematipico
commented
May 26, 2023
matthewp
reviewed
May 26, 2023
matthewp
reviewed
May 26, 2023
ematipico
commented
May 26, 2023
e770d22 to
f98d395
Compare
157af39 to
0e7d932
Compare
Member
Author
|
I rebased the branch. The PR should be ready for review |
bluwy
reviewed
Jun 13, 2023
matthewp
reviewed
Jun 13, 2023
Contributor
|
We discussed offline. Integrations (adapters) will need to know the mapping of routes to the entrypoint. We discussed adding this to the |
bluwy
reviewed
Jun 13, 2023
de11b09 to
d49e185
Compare
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
d4279f3 to
114eec4
Compare
Merged
ArmandPhilippot
added a commit
to ArmandPhilippot/astro-docs
that referenced
this pull request
Jan 29, 2025
`entryPoints` added in withastro/astro#7220 so v2.7.0 `middlewareEntryPoint` added in withastro/astro#7532 so 2.8.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds a new SSR mode, called
split.Serverless mode creates an entry point for each page, and each entry point is a self-contained application meant to render one single page.
Here's a list of changes:
splitboolean to thebuildobject; by default, the value isfalse, which means that Astro will keep the current behaviour;plugin-ssr.tswill emit two plugins, one to emit SSR server and one for SSR split, and they can't coexist. One is used, and the other won't. The reason why the two plugins live in the same file is that they share the majority of the code;plugin-ssr.tsthe code that generates the deserialisation of the manifest was moved into a function, shared between the new plugins;splitvalue.pageMapis kept for SSR server, while SSR split has a simplepageModulefunction. Because of that, I created two types:SSRServerManifestandSSRServerlessManifest;serverlessEntryPrefix; by default it'sentryHere's an example of the emitted output
Testing
Added some test case
Docs
/cc @withastro/maintainers-docs for feedback!
If you're OK with the APIs, then I will start drafting a PR in the docs repo, because now the payload of
astro:build:ssrhas an additional property