Skip to content

[Content collections] Improve content config handling#5824

Merged
bholmesdev merged 5 commits intomainfrom
fix/better-content-config-handling
Jan 11, 2023
Merged

[Content collections] Improve content config handling#5824
bholmesdev merged 5 commits intomainfrom
fix/better-content-config-handling

Conversation

@bholmesdev
Copy link
Copy Markdown
Contributor

@bholmesdev bholmesdev commented Jan 10, 2023

Changes

Better handle content type generation failures:

  • Generate types when content directory is empty
  • Log helpful error when running astro sync without a content directory
  • Avoid swallowing config.ts syntax errors from Vite
  • Fix: Generate types when the content/ dir is added in dev

Testing

Manual testing: adding and removing the content directory, adding and modifying the config.ts file.

Docs

withastro/docs#2345

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 10, 2023

🦋 Changeset detected

Latest commit: 96fb348

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 10, 2023
Copy link
Copy Markdown
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice improvements! LGTM.

@bholmesdev bholmesdev merged commit 665a2c2 into main Jan 11, 2023
@bholmesdev bholmesdev deleted the fix/better-content-config-handling branch January 11, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot find module 'astro:content'

2 participants