Skip to content

[Content collections] Clarify type generation step#2345

Closed
bholmesdev wants to merge 3 commits intomainfrom
edit/make-content-generation-clearer-in-setup
Closed

[Content collections] Clarify type generation step#2345
bholmesdev wants to merge 3 commits intomainfrom
edit/make-content-generation-clearer-in-setup

Conversation

@bholmesdev
Copy link
Copy Markdown
Contributor

What kind of changes does this PR include?

  • New or updated content

Description

  • Add type generation to "Getting Started"
  • Add tips where the astro:content module is used

@netlify
Copy link
Copy Markdown

netlify bot commented Jan 10, 2023

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 8c20e2b
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/63bdf701d3f0db0009786c15
😎 Deploy Preview https://deploy-preview-2345--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m wondering if this might be overkill. Especially as there are some similar tips added in #2313. I’d suggest we wait for the other content collections PRs to merge and also for a PR removing the note about the experimental flag and then regroup here.

@sarah11918 sarah11918 added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label Jan 11, 2023
@bholmesdev
Copy link
Copy Markdown
Contributor Author

Closing in favor of just the Getting Started update. See #2313!

@bholmesdev bholmesdev closed this Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants