Skip to content

chore: avoid formatter conflicts#16897

Merged
ematipico merged 5 commits into
mainfrom
ocavue/biome-unsafe
Jun 2, 2026
Merged

chore: avoid formatter conflicts#16897
ematipico merged 5 commits into
mainfrom
ocavue/biome-unsafe

Conversation

@ocavue

@ocavue ocavue commented May 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

pnpm run format runs biome first, then runs prettier afterward. These two tools have different options regarding packages/language-tools/vscode/languages/astro.code-snippets, so this file gets updated twice every time. In this PR, I ask biome prettier to ignore this file.

Before:

$ pnpm format

  biome format --write && prettier -w "**/*" --ignore-unknown --cache

Formatted 2098 files in 1271ms. Fixed 1 file.

...
packages/language-tools/vscode/languages/astro.code-snippets 1ms
...

After:

$ pnpm format
  
  biome format --write && prettier -w "**/*" --ignore-unknown --cache

Formatted 2097 files in 822ms. No fixes applied.

...
packages/language-tools/vscode/languages/astro.code-snippets 0ms (unchanged) (cached)
...

Testing

CI should pass

Docs

N/A

@changeset-bot

changeset-bot Bot commented May 28, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ff96a47

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added the pkg: integration Related to any renderer integration (scope) label May 28, 2026
@ocavue ocavue force-pushed the ocavue/biome-unsafe branch from e846d4c to 9d647d7 Compare May 28, 2026 21:44
@ocavue ocavue changed the title chore: apply unsafe biome changes chore: avoid formatter conflicts May 28, 2026
@github-actions github-actions Bot removed the pkg: integration Related to any renderer integration (scope) label May 28, 2026
@ocavue ocavue marked this pull request as ready for review May 28, 2026 22:04
ematipico
ematipico requested changes Jun 2, 2026
View reviewed changes

@ematipico ematipico left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use Biome to format JSON files, so we should ignore it with prettier

@ematipico ematipico merged commit d522c18 into main Jun 2, 2026
27 checks passed
@ematipico ematipico deleted the ocavue/biome-unsafe branch June 2, 2026 15:00
ematipico added a commit that referenced this pull request Jun 2, 2026
@ematipico @ocavue
@renovate @felmonon @stefanmachhammer
chore: merge main into next (#16948)
e640ff6 
* chore: move integration tests to unit tests (#16869)

* chore(deps): replace which-pm-runs with package-manager-detector (#16901)

* chore(deps): update dependency hono to v4.12.18 [security] (#16669)

* Fix false positive missing-content audit for hidden anchors (#16016)

* fix: remove dead else branch in csp insertDirective (#16921)

Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>

* chore: avoid formatter conflicts (#16897)

---------

Co-authored-by: ocavue <ocavue@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Felmon <felmonon@gmail.com>
Co-authored-by: Stefan Machhammer <stefan.machhi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ocavue @ematipico