fix: improver double encoding check#16808
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 07a8bbb The changes in this PR will be included in the next version bump. This PR includes changesets to release 413 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matthewp
reviewed
May 20, 2026
matthewp
reviewed
May 20, 2026
| * @throws Error if the pathname contains invalid URL encoding | ||
| */ | ||
| export function validateAndDecodePathname(pathname: string): string { | ||
| if (ENCONDING_REGEX.test(pathname)) { |
Contributor
There was a problem hiding this comment.
I don't think this early check is necessary and it prevents legitimate character combinations like %25AB. Not all uses of %25 are for double encoding.
I think your new test cases would still pass without this.
Member
Author
There was a problem hiding this comment.
Without it, there are a bunch of failures. I added a test for %25AB, with a conservative approach 07a8bbb (this PR)
matthewp
requested changes
May 20, 2026
matthewp
left a comment
Contributor
There was a problem hiding this comment.
the pre-check breaks some legitimate cases.
matthewp
approved these changes
May 20, 2026
Merged
dadezzz
pushed a commit
to dadezzz/university_notes
that referenced
this pull request
May 25, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [astro](https://astro.build) ([source](https://github.com/withastro/astro/tree/HEAD/packages/astro)) | [`6.3.6` → `6.3.7`](https://renovatebot.com/diffs/npm/astro/6.3.6/6.3.7) |  |  | --- ### Release Notes <details> <summary>withastro/astro (astro)</summary> ### [`v6.3.7`](https://github.com/withastro/astro/blob/HEAD/packages/astro/CHANGELOG.md#637) [Compare Source](https://github.com/withastro/astro/compare/astro@6.3.6...astro@6.3.7) ##### Patch Changes - [#​16821](withastro/astro#16821) [`9c76b12`](withastro/astro@9c76b12) Thanks [@​astrobot-houston](https://github.com/astrobot-houston)! - Fixes request body handling in the Node adapter when `req.body` is a `Buffer`, `Uint8Array`, or `ArrayBuffer`. Previously, binary body data was incorrectly JSON-stringified (producing `{"type":"Buffer","data":[...]}`) instead of being passed through directly. This affected libraries like `serverless-http` that set `req.body` to a `Buffer`. - [#​16785](withastro/astro#16785) [`de96360`](withastro/astro@de96360) Thanks [@​astrobot-houston](https://github.com/astrobot-houston)! - Fixes `vite.build.minify`, `vite.build.sourcemap`, and `vite.build.rollupOptions.output` (e.g. `compact`) being ignored for client-side builds. These top-level Vite build options are now properly forwarded to the client environment, with environment-specific overrides (`vite.environments.client.build.*`) taking priority when set. - [#​16819](withastro/astro#16819) [`b5dd8f1`](withastro/astro@b5dd8f1) Thanks [@​astrobot-houston](https://github.com/astrobot-houston)! - Fixes custom elements in MDX files bypassing the renderer pipeline. Custom elements (tags containing hyphens like `<my-element>`) in `.mdx` files are now routed through registered renderers for SSR, matching the behavior of `.astro` files. If no renderer claims the element, it falls back to rendering as raw HTML. - [#​16808](withastro/astro#16808) [`765896c`](withastro/astro@765896c) Thanks [@​ematipico](https://github.com/ematipico)! - Fixes dynamic routes returning 400 Bad Request when the URL contains a literal `%` character, such as paths built with `encodeURIComponent('%?.pdf')` - [#​16804](withastro/astro#16804) [`90d2aca`](withastro/astro@90d2aca) Thanks [@​jp-knj](https://github.com/jp-knj)! - Fixes a v6 regression where `astro:i18n` could not be imported from client `<script>` blocks. </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xODIuMSIsInVwZGF0ZWRJblZlciI6IjQzLjE4Mi4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
1 task
Prayaksh
referenced
this pull request
in withastro/docs
May 30, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Closes #16781
It hardens and fixes the double encoding algorithm.
Testing
Added a bunch of unit tests, and an integration test.
Docs
N/A