chore(deps): dedupe vite installations#16788
Merged
ematipico merged 1 commit intoMay 20, 2026
Merged
Conversation
|
8ee6ced to
f67f970
Compare
vite installations
ematipico
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This is a follow-up to #16787.
The goal of this PR is ensure that we only get one instance of
viteinstalled undernode_modules/.I made the following changes in this PR:
@types/nodedep:@types/nodefrom v20 to v22 in language tools packages. VSCode uses Node v22 since 2025 June, so it should be safe to update this.@types/nodefrom v25 to v22 in the CF package. It's better not to use non-LTS versions anyway.@types/nodepeer dep:dedupePeersconfig.overrideto@types/node. See the inline comment in my code for more details.Testing
Here is how I check my work is correct:
Before:
Two instances of
viteinstalled. One with@types/node@25.2.3and another with@types/node@22.19.11.After:
Singe instance of
viteinstalled, with@types/node@22.19.19.I was thinking about adding a new test to ensure that we only have one
viteinstalled, but it's a bit overkill, IMHO. After all, having multipleviteinstallations won't necessarily cause issues.Docs
N/A