Skip to content

Dedupe vite#16787

Merged
ematipico merged 1 commit into
withastro:chore/merge-main-into-nextfrom
ocavue-forks:ocavue/chore/merge-main-into-next
May 19, 2026
Merged

Dedupe vite#16787
ematipico merged 1 commit into
withastro:chore/merge-main-into-nextfrom
ocavue-forks:ocavue/chore/merge-main-into-next

Conversation

@ocavue

@ocavue ocavue commented May 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

Update esbuild and tsx to the latest versions. This reduces the vite instances installed under node_modules/ and resolves the test failure in Examples astro check / astro check CI job.

Before:

We have 3 vite instances installed. astro and @example/with-vitest use different vite.

$ git status
On branch chore/merge-main-into-next

$ pnpm -r why vite | egrep ' astro@|vite@8|@example|Found'
vite@8.0.13 peer#4033 (3 variations)
│   └── astro@7.0.0-alpha.1 (devDependencies)
├── astro@7.0.0-alpha.1 (dependencies)
│ └── astro@7.0.0-alpha.1 (dependencies)
vite@8.0.13 peer#5d0f (3 variations)
vite@8.0.13 peer#96d1 (3 variations)
│ ├── @example/with-tailwindcss@0.0.1 (dependencies)
│   ├── @example/container-with-vitest@0.0.1 (dependencies)
│   └── @example/with-vitest@0.0.1 (dependencies)

Found 1 version, 3 instances of vite

After:

We have 2 vite instances installed. astro and @example/with-vitest share the same vite.

$ git status
On branch ocavue/chore/merge-main-into-next

$ pnpm -r why vite | egrep ' astro@|vite@8|@example|Found'
vite@8.0.13 peer#1781 (2 variations)
│ ├── @example/with-tailwindcss@0.0.1 (dependencies)
│   ├── @example/container-with-vitest@0.0.1 (dependencies)
│   ├── astro@7.0.0-alpha.1 (devDependencies)
│   └── @example/with-vitest@0.0.1 (dependencies)
├── astro@7.0.0-alpha.1 (dependencies)
│ ├── astro@7.0.0-alpha.1 (dependencies)
vite@8.0.13 peer#ade4 (2 variations)

Found 1 version, 2 instances of vite

Testing

Docs

@changeset-bot

changeset-bot Bot commented May 19, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4bd418c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added feat: markdown Related to Markdown (scope) pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels May 19, 2026
@ocavue ocavue marked this pull request as ready for review May 19, 2026 11:57
ocavue
ocavue commented May 19, 2026
View reviewed changes
Comment thread pnpm-workspace.yaml
# Netlify packages that do not have trusted publishing enabled on npm
# TODO: Remove once trusted publishing is enabled. Netlify are working on it.
- '@netlify/edge-bundler@14.10.1'
- '@netlify/edge-bundler@14.10.2||14.10.1'

@ocavue ocavue May 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewers:

I also updated @netlify/edge-bundler to 14.10.2 to bump the indirect esbuild it uses.

@ematipico ematipico merged commit ce88423 into withastro:chore/merge-main-into-next May 19, 2026
17 of 26 checks passed
@ocavue ocavue mentioned this pull request May 20, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ocavue @ematipico