fix(content-layer): populate imagePaths in renderMarkdown metadata by chasemccoy · Pull Request #15968 · withastro/astro

chasemccoy · 2026-03-17T23:45:36Z

Summary

renderMarkdown from LoaderContext returns image paths as metadata.localImagePaths and metadata.remoteImagePaths (separate arrays), but the runtime's renderEntry function checks for a combined metadata.imagePaths to decide whether to resolve __ASTRO_IMAGE_ placeholders into optimized <img> tags.

Because imagePaths is never set by renderMarkdown, images in custom loaders that use it are never resolved — the __ASTRO_IMAGE_ attributes remain in the final HTML.

The built-in glob() loader avoids this because it uses entryType.getRenderFunction(config), which explicitly combines the two arrays:

return {
  html: result.code,
  metadata: {
    ...result.metadata,
    imagePaths: result.metadata.localImagePaths.concat(result.metadata.remoteImagePaths),
  },
};

This PR applies the same combination in #processMarkdown (which backs the renderMarkdown context helper), so custom loaders get the same image optimization behavior as the built-in glob() loader.

Changes

packages/astro/src/content/content-layer.ts: In #processMarkdown, spread metadata and add a combined imagePaths field from localImagePaths + remoteImagePaths.

Notes

Custom loaders also need to pass assetImports to store.set() for the images to be registered with Vite's asset pipeline. This is required alongside the imagePaths metadata fix. It may be worth documenting this in the Content Loader API reference, or having store.set() automatically extract imagePaths from rendered.metadata when assetImports isn't explicitly provided.

Test plan

Create a custom object loader that uses renderMarkdown with markdown containing relative image paths
Verify images render correctly (no __ASTRO_IMAGE_ placeholders in output)
Verify existing glob() loader behavior is unchanged

Made with Cursor

`renderMarkdown` from `LoaderContext` returned `localImagePaths` and `remoteImagePaths` as separate metadata fields, but the runtime's `renderEntry` function checks for a combined `imagePaths` field to decide whether to resolve `__ASTRO_IMAGE_` placeholders. This caused images in custom loaders using `renderMarkdown` to never be optimized. Combines the two arrays into `imagePaths` in `#processMarkdown`, matching the behavior of the markdown content entry type's `getRenderFunction`. Made-with: Cursor

changeset-bot · 2026-03-17T23:45:42Z

🦋 Changeset detected

Latest commit: 318512a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Adds a test that ensures renderMarkdown returns a combined `imagePaths` array in the rendered metadata, which is required by the runtime's `renderEntry` to resolve __ASTRO_IMAGE_ placeholders. Made-with: Cursor

codspeed-hq · 2026-03-18T00:03:22Z

Merging this PR will not alter performance

✅ 18 untouched benchmarks

_{Comparing chasemccoy:fix/rendermarkdown-imagepaths (318512a) with main (4741b09)}

.changeset/fix-rendermarkdown-imagepaths.md

Made-with: Cursor

This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [astro](https://astro.build) ([source](https://github.com/withastro/astro/tree/HEAD/packages/astro)) | [`6.0.6` → `6.0.8`](https://renovatebot.com/diffs/npm/astro/6.0.6/6.0.8) | ![age](https://developer.mend.io/api/mc/badges/age/npm/astro/6.0.8?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/astro/6.0.6/6.0.8?slim=true) | --- ### Release Notes <details> <summary>withastro/astro (astro)</summary> ### [`v6.0.8`](https://github.com/withastro/astro/blob/HEAD/packages/astro/CHANGELOG.md#608) [Compare Source](https://github.com/withastro/astro/compare/astro@6.0.7...astro@6.0.8) ##### Patch Changes - [#15978](withastro/astro#15978) [`6d182fe`](withastro/astro@6d182fe) Thanks [@seroperson](https://github.com/seroperson)! - Fixes a bug where Astro Actions didn't properly support nested object properties, causing problems when users used zod functions such as `superRefine` or `discriminatedUnion`. - [#16011](withastro/astro#16011) [`e752170`](withastro/astro@e752170) Thanks [@matthewp](https://github.com/matthewp)! - Fixes a dev server hang on the first request when using the Cloudflare adapter - [#15997](withastro/astro#15997) [`1fddff7`](withastro/astro@1fddff7) Thanks [@ematipico](https://github.com/ematipico)! - Fixes `Astro.rewrite()` failing when the target path contains duplicate slashes (e.g. `//about`). The duplicate slashes are now collapsed before URL parsing, preventing them from being interpreted as a protocol-relative URL. ### [`v6.0.7`](https://github.com/withastro/astro/blob/HEAD/packages/astro/CHANGELOG.md#607) [Compare Source](https://github.com/withastro/astro/compare/astro@6.0.6...astro@6.0.7) ##### Patch Changes - [#15950](withastro/astro#15950) [`acce5e8`](withastro/astro@acce5e8) Thanks [@matthewp](https://github.com/matthewp)! - Fixes a build regression in projects with multiple frontend integrations where `server:defer` server islands could fail at runtime when all pages are prerendered. - [#15988](withastro/astro#15988) [`c93b4a0`](withastro/astro@c93b4a0) Thanks [@ossaidqadri](https://github.com/ossaidqadri)! - Fix styles from dynamically imported components not being injected on first dev server load. - [#15968](withastro/astro#15968) [`3e7a9d5`](withastro/astro@3e7a9d5) Thanks [@chasemccoy](https://github.com/chasemccoy)! - Fixes `renderMarkdown` in custom content loaders not resolving images in markdown content. Images referenced in markdown processed by `renderMarkdown` are now correctly optimized, matching the behavior of the built-in `glob()` loader. - [#15990](withastro/astro#15990) [`1e6017f`](withastro/astro@1e6017f) Thanks [@ematipico](https://github.com/ematipico)! - Fixes an issue where `Astro.currentLocale` would always be the default locale instead of the actual one when using a dynamic route like `[locale].astro` or `[locale]/index.astro`. It now resolves to the correct locale from the URL. - [#15990](withastro/astro#15990) [`1e6017f`](withastro/astro@1e6017f) Thanks [@ematipico](https://github.com/ematipico)! - Fixes an issue where visiting an invalid locale URL (e.g. `/asdf/`) would show the content of a dynamic `[locale]` page with a 404 status code, instead of showing your custom 404 page. Now, the correct 404 page is rendered when the locale in the URL doesn't match any configured locale. - [#15960](withastro/astro#15960) [`1d84020`](withastro/astro@1d84020) Thanks [@matthewp](https://github.com/matthewp)! - Fixes Cloudflare dev server islands with `prerenderEnvironment: 'node'` by sharing the serialized manifest encryption key across dev environments and routing server island requests through the SSR runtime. - [#15735](withastro/astro#15735) [`9685e2d`](withastro/astro@9685e2d) Thanks [@fa-sharp](https://github.com/fa-sharp)! - Fixes an EventEmitter memory leak when serving static pages from Node.js middleware. When using the middleware handler, requests that were being passed on to Express / Fastify (e.g. static files / pre-rendered pages / etc.) weren't cleaning up socket listeners before calling `next()`, causing a memory leak warning. This fix makes sure to run the cleanup before calling `next()`. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: Renovate Bot <renovate@zarantonello.dev> Co-committed-by: Renovate Bot <renovate@zarantonello.dev>

github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 17, 2026

test: verify renderMarkdown populates combined imagePaths metadata

aa6494d

Adds a test that ensures renderMarkdown returns a combined `imagePaths` array in the rendered metadata, which is required by the runtime's `renderEntry` to resolve __ASTRO_IMAGE_ placeholders. Made-with: Cursor

matthewp reviewed Mar 19, 2026

View reviewed changes

.changeset/fix-rendermarkdown-imagepaths.md Outdated Show resolved Hide resolved

chasemccoy added 2 commits March 19, 2026 10:30

chore: rephrase changeset per contribution guidelines

8e84471

Made-with: Cursor

chore: rephrase changeset for end users

318512a

Made-with: Cursor

chasemccoy requested a review from matthewp March 19, 2026 16:36

matthewp approved these changes Mar 19, 2026

View reviewed changes

matthewp merged commit 3e7a9d5 into withastro:main Mar 19, 2026
43 of 44 checks passed

astrobot-houston mentioned this pull request Mar 19, 2026

[ci] release #15985

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(content-layer): populate imagePaths in renderMarkdown metadata#15968

fix(content-layer): populate imagePaths in renderMarkdown metadata#15968
matthewp merged 4 commits intowithastro:mainfrom
chasemccoy:fix/rendermarkdown-imagepaths

chasemccoy commented Mar 17, 2026

Uh oh!

changeset-bot bot commented Mar 17, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Mar 18, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

chasemccoy commented Mar 17, 2026

Summary

Changes

Notes

Test plan

Uh oh!

changeset-bot bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

codspeed-hq bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot bot commented Mar 17, 2026 •

edited

Loading

codspeed-hq bot commented Mar 18, 2026 •

edited

Loading