fix(hmr): normalize paths when reloading manifest#15937
Merged
Conversation
🦋 Changeset detectedLatest commit: 941b449 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
f2ebdce to
941b449
Compare
commit: |
Eveeifyeve
reviewed
Mar 17, 2026
Contributor
Eveeifyeve
left a comment
There was a problem hiding this comment.
I don't have approve permissions, But I do approve of this.
matthewp
approved these changes
Mar 17, 2026
Merged
dadezzz
pushed a commit
to dadezzz/ice-notes
that referenced
this pull request
Mar 22, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [astro](https://astro.build) ([source](https://github.com/withastro/astro/tree/HEAD/packages/astro)) | [`6.0.5` → `6.0.6`](https://renovatebot.com/diffs/npm/astro/6.0.5/6.0.6) |  |  | --- ### Release Notes <details> <summary>withastro/astro (astro)</summary> ### [`v6.0.6`](https://github.com/withastro/astro/blob/HEAD/packages/astro/CHANGELOG.md#606) [Compare Source](https://github.com/withastro/astro/compare/astro@6.0.5...astro@6.0.6) ##### Patch Changes - [#​15965](withastro/astro#15965) [`2dca307`](withastro/astro@2dca307) Thanks [@​matthewp](https://github.com/matthewp)! - Fixes client hydration for components imported through Node.js subpath imports (`package.json#imports`, e.g. `#components/*`), for example when using the Cloudflare adapter in development. - [#​15770](withastro/astro#15770) [`6102ca2`](withastro/astro@6102ca2) Thanks [@​jpc-ae](https://github.com/jpc-ae)! - Updates the `create astro` welcome message to highlight the graceful dev/preview server quit command rather than the kill process shortcut - [#​15953](withastro/astro#15953) [`7eddf22`](withastro/astro@7eddf22) Thanks [@​Desel72](https://github.com/Desel72)! - fix(hmr): eagerly recompile on style-only change to prevent stale slots render - [#​15916](withastro/astro#15916) [`5201ed4`](withastro/astro@5201ed4) Thanks [@​trueberryless](https://github.com/trueberryless)! - Fixes `InferLoaderSchema` type inference for content collections defined with a loader that includes a `schema` - [#​15864](withastro/astro#15864) [`d3c7de9`](withastro/astro@d3c7de9) Thanks [@​florian-lefebvre](https://github.com/florian-lefebvre)! - Removes temporary support for Node >=20.19.1 because Stackblitz now uses Node 22 by default - [#​15944](withastro/astro#15944) [`a5e1acd`](withastro/astro@a5e1acd) Thanks [@​fkatsuhiro](https://github.com/fkatsuhiro)! - Fixes SSR dynamic routes with `.html` extension (e.g. `[slug].html.astro`) not working - [#​15937](withastro/astro#15937) [`d236245`](withastro/astro@d236245) Thanks [@​ematipico](https://github.com/ematipico)! - Fixes an issue where HMR didn't correctly work on Windows when adding/changing/deleting routes in `pages/`. - [#​15931](withastro/astro#15931) [`98dfb61`](withastro/astro@98dfb61) Thanks [@​Strernd](https://github.com/Strernd)! - Fix skew protection query params not being applied to island hydration `component-url` and `renderer-url`, and ensure query params are appended safely for asset URLs with existing search/hash parts. - Updated dependencies \[]: - [@​astrojs/markdown-remark](https://github.com/astrojs/markdown-remark)@​7.0.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My43Ni4yIiwidXBkYXRlZEluVmVyIjoiNDMuNzYuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: Renovate Bot <renovate@zarantonello.dev> Co-committed-by: Renovate Bot <renovate@zarantonello.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Closes #15909
In HMR, when checking if we need to reload the manifest, we now normalise paths.
Using Node.js and vite is safe, we're inside a vite plugin.
Testing
I don't have windows and we skip these tests on windows. Will probably use a preview release.
Docs
N/A