Skip to content

fix: infer numbers as strings in InferGetStaticParamsType#14587

Closed
ocavue wants to merge 4 commits intowithastro:mainfrom
ocavue-forks:ocavue/static-param-type
Closed

fix: infer numbers as strings in InferGetStaticParamsType#14587
ocavue wants to merge 4 commits intowithastro:mainfrom
ocavue-forks:ocavue/static-param-type

Conversation

@ocavue
Copy link
Copy Markdown
Contributor

@ocavue ocavue commented Oct 20, 2025

Changes

Update the TS type InferGetStaticParamsType to infer all numbers as strings.

Closes #14057

This is an alternative to #14586

Testing

Docs

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 20, 2025

🦋 Changeset detected

Latest commit: fe0fbea

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) docs pr labels Oct 20, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Oct 20, 2025

CodSpeed Performance Report

Merging #14587 will not alter performance

Comparing ocavue:ocavue/static-param-type (fe0fbea) with main (7958c6b)1

Summary

✅ 6 untouched

Footnotes

  1. No successful run was found on main (ca1d331) during the generation of this report, so 7958c6b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs pr pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Astro.params has a wrong type

2 participants