Skip to content

refactor(actions): plugin and virtual modules#14538

Merged
florian-lefebvre merged 11 commits intomainfrom
feat/refactor-actions-plugin
Oct 16, 2025
Merged

refactor(actions): plugin and virtual modules#14538
florian-lefebvre merged 11 commits intomainfrom
feat/refactor-actions-plugin

Conversation

@florian-lefebvre
Copy link
Copy Markdown
Member

@florian-lefebvre florian-lefebvre commented Oct 14, 2025

Changes

  • Extracted from feat: update actions to not use proxies #14484 and feat: zod v4 #14529
  • While working on actions recently, I found several things could be improved
    • Use a single vite plugin
    • We don't need codegen, I updated the implementation to be closer to virtual-modules/i18n.ts. Allowed to spot some runtime things that were incorrect
    • Things in actions/runtime/virtual were not only imported by the virtual module, so I moved them to actions/runtime
  • This will help by being more consistent with other features, and will make the Zod 4 PR diff smaller

Testing

Should pass

Docs

Technically doesn't need a changeset but I'll include one to be safe

@florian-lefebvre florian-lefebvre self-assigned this Oct 14, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 14, 2025

🦋 Changeset detected

Latest commit: da1d710

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 14, 2025
@florian-lefebvre florian-lefebvre marked this pull request as ready for review October 14, 2025 13:31
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Oct 14, 2025

CodSpeed Performance Report

Merging #14538 will not alter performance

Comparing feat/refactor-actions-plugin (da1d710) with main (62ec8ea)1

Summary

✅ 6 untouched

Footnotes

  1. No successful run was found on main (4632db3) during the generation of this report, so 62ec8ea was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Copy link
Copy Markdown
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, that's a great refactor. Thank you @florian-lefebvre! I left some comments, but they are mostly open-ended

@florian-lefebvre florian-lefebvre merged commit 51ebe6a into main Oct 16, 2025
23 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/refactor-actions-plugin branch October 16, 2025 12:19
@astrobot-houston astrobot-houston mentioned this pull request Oct 16, 2025
richardnbanks pushed a commit to richardnbanks/astro-loader-youtube that referenced this pull request Oct 19, 2025
This PR contains the following updates:

| Package | Change | Age | Confidence |
|---|---|---|---|
| [astro](https://astro.build) ([source](https://github.com/withastro/astro/tree/HEAD/packages/astro)) | [`5.14.5` -> `5.14.6`](https://renovatebot.com/diffs/npm/astro/5.14.5/5.14.6) | [![age](https://developer.mend.io/api/mc/badges/age/npm/astro/5.14.6?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/astro/5.14.5/5.14.6?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>withastro/astro (astro)</summary>

### [`v5.14.6`](https://github.com/withastro/astro/blob/HEAD/packages/astro/CHANGELOG.md#5146)

[Compare Source](https://github.com/withastro/astro/compare/astro@5.14.5...astro@5.14.6)

##### Patch Changes

- [#&#8203;14562](withastro/astro#14562) [`722bba0`](withastro/astro@722bba0) Thanks [@&#8203;erbierc](https://github.com/erbierc)! - Fixes a bug where the behavior of the "muted" HTML attribute was inconsistent with that of other attributes.

- [#&#8203;14538](withastro/astro#14538) [`51ebe6a`](withastro/astro@51ebe6a) Thanks [@&#8203;florian-lefebvre](https://github.com/florian-lefebvre)! - Improves how Actions are implemented

- [#&#8203;14548](withastro/astro#14548) [`6cdade4`](withastro/astro@6cdade4) Thanks [@&#8203;ascorbic](https://github.com/ascorbic)! - Removes support for the `maxAge` property in `cacheHint` objects returned by live loaders.

##### ⚠️ Breaking change for experimental live content collections only

Feedback showed that this did not make sense to set at the loader level, since the loader does not know how long each individual entry should be cached for.

If your live loader returns cache hints with `maxAge`, you need to remove this property:

```diff
return {
  entries: [...],
  cacheHint: {
    tags: ['my-tag'],
-   maxAge: 60,
    lastModified: new Date(),
  },
};
```

The `cacheHint` object now only supports `tags` and `lastModified` properties. If you want to set the max age for a page, you can set the headers manually:

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS45OS4xMSIsInVwZGF0ZWRJblZlciI6IjQxLjk5LjExIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Reviewed-on: https://code.richardbanks.dev/richard/astro-loader-youtube/pulls/21
Co-authored-by: Renovate Bot <renovate-bot@richardbanks.dev>
Co-committed-by: Renovate Bot <renovate-bot@richardbanks.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs pr pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants