refactor(actions): plugin and virtual modules#14538
Merged
florian-lefebvre merged 11 commits intomainfrom Oct 16, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: da1d710 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #14538 will not alter performanceComparing Summary
Footnotes |
ematipico
approved these changes
Oct 16, 2025
Member
ematipico
left a comment
There was a problem hiding this comment.
Overall, that's a great refactor. Thank you @florian-lefebvre! I left some comments, but they are mostly open-ended
ematipico
approved these changes
Oct 16, 2025
Merged
1 task
richardnbanks
pushed a commit
to richardnbanks/astro-loader-youtube
that referenced
this pull request
Oct 19, 2025
This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [astro](https://astro.build) ([source](https://github.com/withastro/astro/tree/HEAD/packages/astro)) | [`5.14.5` -> `5.14.6`](https://renovatebot.com/diffs/npm/astro/5.14.5/5.14.6) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>withastro/astro (astro)</summary> ### [`v5.14.6`](https://github.com/withastro/astro/blob/HEAD/packages/astro/CHANGELOG.md#5146) [Compare Source](https://github.com/withastro/astro/compare/astro@5.14.5...astro@5.14.6) ##### Patch Changes - [#​14562](withastro/astro#14562) [`722bba0`](withastro/astro@722bba0) Thanks [@​erbierc](https://github.com/erbierc)! - Fixes a bug where the behavior of the "muted" HTML attribute was inconsistent with that of other attributes. - [#​14538](withastro/astro#14538) [`51ebe6a`](withastro/astro@51ebe6a) Thanks [@​florian-lefebvre](https://github.com/florian-lefebvre)! - Improves how Actions are implemented - [#​14548](withastro/astro#14548) [`6cdade4`](withastro/astro@6cdade4) Thanks [@​ascorbic](https://github.com/ascorbic)! - Removes support for the `maxAge` property in `cacheHint` objects returned by live loaders. #####⚠️ Breaking change for experimental live content collections only Feedback showed that this did not make sense to set at the loader level, since the loader does not know how long each individual entry should be cached for. If your live loader returns cache hints with `maxAge`, you need to remove this property: ```diff return { entries: [...], cacheHint: { tags: ['my-tag'], - maxAge: 60, lastModified: new Date(), }, }; ``` The `cacheHint` object now only supports `tags` and `lastModified` properties. If you want to set the max age for a page, you can set the headers manually: </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS45OS4xMSIsInVwZGF0ZWRJblZlciI6IjQxLjk5LjExIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Reviewed-on: https://code.richardbanks.dev/richard/astro-loader-youtube/pulls/21 Co-authored-by: Renovate Bot <renovate-bot@richardbanks.dev> Co-committed-by: Renovate Bot <renovate-bot@richardbanks.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
virtual-modules/i18n.ts. Allowed to spot some runtime things that were incorrectactions/runtime/virtualwere not only imported by the virtual module, so I moved them toactions/runtimeTesting
Should pass
Docs
Technically doesn't need a changeset but I'll include one to be safe