Fix compatibility with older Astro versions in @astrojs/node#14514
Merged
Fix compatibility with older Astro versions in @astrojs/node#14514
Conversation
- Make getAllowedDomains() call optional with fallback to empty array - Update peer dependency to require astro@^5.14.3 - Fixes #14513
🦋 Changeset detectedLatest commit: 8ebccd8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Princesseuh
reviewed
Oct 10, 2025
| try { | ||
| request = NodeApp.createRequest(req, { | ||
| allowedDomains: app.getAllowedDomains(), | ||
| allowedDomains: app.getAllowedDomains?.() ?? [], |
Member
There was a problem hiding this comment.
Are there any restrictions with this being an empty array vs it being completely missing in previous versions?
Contributor
Author
There was a problem hiding this comment.
The option just didn't exist in previous versions, so we'd be passing an empty array that gets ignored. Seems fine?
Princesseuh
approved these changes
Oct 10, 2025
Merged
florian-lefebvre
added a commit
that referenced
this pull request
Oct 13, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Matthew Phillips <matthew@skypack.dev> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev> Co-authored-by: Matthew Phillips <matthewp@users.noreply.github.com> Co-authored-by: Houston (Bot) <108291165+astrobot-houston@users.noreply.github.com> Co-authored-by: Bartosz Kapciak <bartosz.kapciak@swmansion.com> Co-authored-by: Bartosz Kapciak <martrapp@users.noreply.github.com> Co-authored-by: Armand Philippot <git@armand.philippot.eu> Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com> Co-authored-by: Abdelrahman Abdelfattah <spices.digital@gmail.com> Co-authored-by: Alasdair McLeay <penx@users.noreply.github.com> Fix failing x-forwarded-host tests (#14505) fix(prefetch): Fix "tap" prefetch strategy when view transitions are enabled (#14235) fix `security.allowedDomains` version (#14509) Fix compatibility with older Astro versions in @astrojs/node (#14514) Fixes #14513 fix heading level in config reference docs (#14517) fix(deps): update all non-major dependencies (#14522)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Testing
N/A
Docs
N/A