Skip to content

refactor(cli): create-key#14501

Merged
florian-lefebvre merged 3 commits intomainfrom
refactor/cli-create-key
Oct 13, 2025
Merged

refactor(cli): create-key#14501
florian-lefebvre merged 3 commits intomainfrom
refactor/cli-create-key

Conversation

@florian-lefebvre
Copy link
Copy Markdown
Member

@florian-lefebvre florian-lefebvre commented Oct 7, 2025

Changes

  • Updates the implementation of CLI's create-key command so it's unit testable

Testing

Adds a unit test

Docs

N/A, internal refactor. Will send a docs PR tho because it's not documented in the CLI reference

@florian-lefebvre florian-lefebvre self-assigned this Oct 7, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 7, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: e68f999

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 7, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Oct 7, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #14501 will not alter performance

Comparing refactor/cli-create-key (e68f999) with main (3a3a7fe)1

Summary

✅ 6 untouched

Footnotes

  1. No successful run was found on main (e292758) during the generation of this report, so 3a3a7fe was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@florian-lefebvre florian-lefebvre mentioned this pull request Oct 7, 2025
Merged
@florian-lefebvre florian-lefebvre merged commit cd30254 into main Oct 13, 2025
21 checks passed
@florian-lefebvre florian-lefebvre deleted the refactor/cli-create-key branch October 13, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewp matthewp matthewp approved these changes

@ematipico ematipico ematipico approved these changes

Assignees

@florian-lefebvre florian-lefebvre

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@florian-lefebvre @matthewp @ematipico