Skip to content

feat(fonts): warn on unsupported family name#14475

Merged
florian-lefebvre merged 5 commits intomainfrom
feat/fonts-warn-unsupported-family-name
Oct 3, 2025
Merged

feat(fonts): warn on unsupported family name#14475
florian-lefebvre merged 5 commits intomainfrom
feat/fonts-warn-unsupported-family-name

Conversation

@florian-lefebvre
Copy link
Copy Markdown
Member

@florian-lefebvre florian-lefebvre commented Oct 2, 2025

Changes

  • Until now, if unifont couldn't resolve font data for a given family, we should show a generic message. It is valid in some cases
  • However in most cases this is due to a config issue, eg. a typo in the font family name
  • So we add a log for it

Testing

Adds unit tests

Docs

Changesets

@florian-lefebvre florian-lefebvre self-assigned this Oct 2, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 2, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 8055786

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 2, 2025
florian-lefebvre
florian-lefebvre commented Oct 2, 2025
View reviewed changes
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Oct 2, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #14475 will not alter performance

Comparing feat/fonts-warn-unsupported-family-name (8055786) with main (916f9c2)

Summary

✅ 6 untouched

ascorbic
ascorbic reviewed Oct 2, 2025
View reviewed changes
ascorbic
ascorbic reviewed Oct 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work ok with Google Fonts in practice?

@florian-lefebvre
Copy link
Copy Markdown
Member Author

florian-lefebvre commented Oct 3, 2025

Here is how it looks, wdyt?
image

ascorbic
ascorbic approved these changes Oct 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@florian-lefebvre florian-lefebvre merged commit ae034ae into main Oct 3, 2025
22 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/fonts-warn-unsupported-family-name branch October 3, 2025 11:35
@astrobot-houston astrobot-houston mentioned this pull request Oct 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ascorbic ascorbic ascorbic approved these changes

Assignees

@florian-lefebvre florian-lefebvre

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@florian-lefebvre @ascorbic