fix(astro): astro:config/server urls serialization#14460
fix(astro): astro:config/server urls serialization#14460florian-lefebvre merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 7ea3d82 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #14460 will not alter performanceComparing Summary
|
| <p id="out-dir">{outDir}</p> | ||
| <p id="src-dir">{srcDir}</p> | ||
| <p id="root">{root}</p> | ||
| <p id="root-type">{typeof root}</p> |
There was a problem hiding this comment.
How about testing instanceof URL?
There was a problem hiding this comment.
Yeah I don't know why I didn't do that, updated!
| if (Array.isArray(value)) { | ||
| return JSON.stringify(value); | ||
| } |
There was a problem hiding this comment.
Are arrays always of scalars?
There was a problem hiding this comment.
Updated to handle this case
delucis
left a comment
There was a problem hiding this comment.
LGTM! Is there any risk this is now a breaking change for anyone using this as a string? Or do we think the types should be the source of truth?
|
Yeah I thought about this and I think the types should be the source of truth here |
Changes
astro:config/serverURLS, which were emitted as strings instead of URLsTesting
Updated
Docs
Changeset