Skip to content

fix(astro): type assertions#14343

Merged
florian-lefebvre merged 2 commits intomainfrom
fix/buffer-type-assertion
Sep 11, 2025
Merged

fix(astro): type assertions#14343
florian-lefebvre merged 2 commits intomainfrom
fix/buffer-type-assertion

Conversation

@florian-lefebvre
Copy link
Copy Markdown
Member

Changes

  • TS changed the definitions of some types, so I tried to convert data properly in 441d7dc (#14304)
  • However this breaks eg. cloudflare, so insted I replaced those by type casts

Testing

Should pass

Docs

Changeset

@florian-lefebvre florian-lefebvre self-assigned this Sep 11, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Sep 11, 2025

🦋 Changeset detected

Latest commit: 9bbfce8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 11, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Sep 11, 2025

CodSpeed Performance Report

Merging #14343 will not alter performance

Comparing fix/buffer-type-assertion (9bbfce8) with main (f75fd99)

Summary

✅ 6 untouched benchmarks

);

return new Response(Buffer.from(data), {
return new Response(data as Uint8Array<ArrayBuffer>, {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does data.buffer work?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried and no it doesn't unfortunately

@florian-lefebvre florian-lefebvre merged commit 13f7d36 into main Sep 11, 2025
21 checks passed
@florian-lefebvre florian-lefebvre deleted the fix/buffer-type-assertion branch September 11, 2025 09:49
@astrobot-houston astrobot-houston mentioned this pull request Sep 11, 2025
openscript pushed a commit to openscript/astro that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants