Skip to content

feat(fonts): better dev hashes#14279

Merged
florian-lefebvre merged 6 commits intomainfrom
feat/fonts-better-dev-hashes
Sep 23, 2025
Merged

feat(fonts): better dev hashes#14279
florian-lefebvre merged 6 commits intomainfrom
feat/fonts-better-dev-hashes

Conversation

@florian-lefebvre
Copy link
Copy Markdown
Member

@florian-lefebvre florian-lefebvre commented Aug 28, 2025

Changes

  • Feedback from the RFC
  • In development, update the generated font file url to contain information about its origin (font name, weight, style)

Testing

Adds unit tests

Docs

No changeset because this is a refactoring not affecting a public API

@florian-lefebvre florian-lefebvre self-assigned this Aug 28, 2025
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 28, 2025

⚠️ No Changeset found

Latest commit: 71f7b70

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 28, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Aug 28, 2025

CodSpeed Performance Report

Merging #14279 will not alter performance

Comparing feat/fonts-better-dev-hashes (71f7b70) with main (f59581f)1

Summary

✅ 6 untouched

Footnotes

  1. No successful run was found on main (54dcd04) during the generation of this report, so f59581f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@florian-lefebvre florian-lefebvre marked this pull request as ready for review August 28, 2025 12:31
return {
resolve(input) {
const { cssVariable, data } = input;
return [cssVariable.slice(2), data.weight, data.style, baseHashResolver.resolve(input)]
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may have access to the subset if unjs/unifont#242 is approved

@florian-lefebvre florian-lefebvre merged commit 2b4c031 into main Sep 23, 2025
20 of 21 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/fonts-better-dev-hashes branch September 23, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants