refactor: use ssr environment to load modules#14191
Merged
ematipico merged 12 commits intofeat/environment-apifrom Aug 7, 2025
Merged
refactor: use ssr environment to load modules#14191ematipico merged 12 commits intofeat/environment-apifrom
ematipico merged 12 commits intofeat/environment-apifrom
Conversation
|
09f001e to
f1e9743
Compare
f1e9743 to
5223cb9
Compare
ascorbic
reviewed
Aug 6, 2025
packages/astro/src/assets/fonts/implementations/remote-font-provider-mod-resolver.ts
Outdated
Show resolved
Hide resolved
ascorbic
reviewed
Aug 6, 2025
5223cb9 to
3bee8e9
Compare
3bee8e9 to
4cd8c3e
Compare
644d10f to
cb5103a
Compare
ematipico
added a commit
that referenced
this pull request
Sep 2, 2025
ematipico
added a commit
that referenced
this pull request
Sep 3, 2025
ematipico
added a commit
that referenced
this pull request
Sep 3, 2025
* refactor: use environments to load modules (#14191) * refactor: make `App` more extensible using `BaseApp` (#14197) * refactor: App to extends the new BaseApp (#14213) * refactor: manifest as virtual module (#14298) * refactor: create `generate` when needed * fix type * remove type * fix types * fix breakage of code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR removes the use of
ssrLoadModulein favour of the new way: pulling a runnable environment and use the functionrunner.import. Here's the docs: https://vite.dev/guide/api-environment-frameworks.html#runnabledevenvironmentUnfortunately there are few places where we pass the instances of the server, so for my next PR I will refactor those places to accept an environment instead of the instance of the server.
Testing
Current tests should pass
Docs
N/A