Skip to content

Expand ActionError codes to include all IANA HTTP error codes#13769

Merged
ascorbic merged 2 commits into
withastro:mainfrom
romanstetsyk:iana-action-error-codes
May 21, 2025
Merged

Expand ActionError codes to include all IANA HTTP error codes#13769
ascorbic merged 2 commits into
withastro:mainfrom
romanstetsyk:iana-action-error-codes

Conversation

@romanstetsyk

Copy link
Copy Markdown
Contributor

Changes

Expand ActionError codes to include all IANA-registered HTTP error codes. Related discussion.

Possible issues that can affect existing projects:

  • 405 TIMEOUT replaced by 405 METHOD_NOT_ALLOWED, which is the accurate name for the 405 code. REQUEST_TIMEOUT is 408.
  • 413 PAYLOAD_TOO_LARGE replaced by 413 CONTENT_TOO_LARGE.
  • 499 CLIENT_CLOSED_REQUEST removed as non-standard.

Testing

No tests written. Tested by linking the local astro fork using pnpm link.

Docs

The expanded list of error codes doesn’t affect existing documented behavior.

@changeset-bot

changeset-bot Bot commented May 8, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 28f465d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the pkg: astro Related to the core `astro` package (scope) label May 8, 2025
@codspeed-hq

codspeed-hq Bot commented May 8, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #13769 will not alter performance

Comparing romanstetsyk:iana-action-error-codes (28f465d) with main (85b19d8)

Summary

✅ 6 untouched benchmarks

@ascorbic ascorbic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ascorbic ascorbic merged commit e9fc456 into withastro:main May 21, 2025
27 of 28 checks passed
@astrobot-houston astrobot-houston mentioned this pull request May 21, 2025
openscript pushed a commit to openscript/astro that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants