Merged
Conversation
🦋 Changeset detectedLatest commit: ceff5f2 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
astro
@astrojs/cloudflare
@astrojs/netlify
@astrojs/node
@astrojs/vercel
commit: |
delucis
requested changes
Apr 3, 2025
Member
delucis
left a comment
There was a problem hiding this comment.
Thanks for the quick response @ematipico!
CodSpeed Performance ReportMerging #13552 will not alter performanceComparing Summary
|
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
delucis
approved these changes
Apr 3, 2025
Member
delucis
left a comment
There was a problem hiding this comment.
Thanks for the explanation. Makes sense. Left one more thing to consider in case we’d risk breaking things for anyone.
delucis
approved these changes
Apr 3, 2025
Merged
openscript
pushed a commit
to openscript/astro
that referenced
this pull request
Sep 12, 2025
* fix(i18n): incorrect validation * Update packages/astro/src/core/config/schemas/refined.ts Co-authored-by: Chris Swithinbank <swithinbank@gmail.com> * Update .changeset/old-animals-shop.md Co-authored-by: Chris Swithinbank <swithinbank@gmail.com> * update tests * update fixture * track default value too * remove validation --------- Co-authored-by: Chris Swithinbank <swithinbank@gmail.com> Co-authored-by: delucis <357379+delucis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Closes #13551
After 5.6.0, where we changed how we validate the astro configuration, we found out that Astro was validating incorrect values for `i18n.routing.
This PR fixes the values.
Testing
Updated tests and error message.
Docs
cc @delucis and @HiDeoo