fix: renderToString function not render properly nested slots when they are components#13432
Merged
ematipico merged 4 commits intowithastro:mainfrom Mar 18, 2025
Merged
Conversation
* add force HTMLString with local tests * remove local test & logs * remove test counter in basic exemple * re-add test & create SlotString instead of HTMLString
🦋 Changeset detectedLatest commit: afeff3b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #13432 will not alter performanceComparing Summary
|
ematipico
reviewed
Mar 18, 2025
ematipico
reviewed
Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #13067
In the initial issue, all slots passed to the renderToString function are considered strings, so when we pass them to the renderChild function, the HTML escaper breaks the component.
When a slot is passed to the renderToString function, a new SlotString is created.
I created a SlotString for now, but I don't know if this solution is the best approach (it's my first PR on Astro).
Let me know if it's correct or not. :)
Testing
I added a case inside
container-with-vitest\test\Card.test.tsthat reproduces the case displayed on the issue here.Docs
The documentation is already present as mentioned by the initial issue.