Revert "Replace internal cssScopeTo implementation to vite.cssScopeTo"#13420
Merged
Revert "Replace internal cssScopeTo implementation to vite.cssScopeTo"#13420
Conversation
🦋 Changeset detectedLatest commit: a94a72a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
astro
@astrojs/cloudflare
@astrojs/netlify
@astrojs/node
@astrojs/vercel
commit: |
ascorbic
approved these changes
Mar 13, 2025
CodSpeed Performance ReportMerging #13420 will not alter performanceComparing Summary
|
ematipico
commented
Mar 13, 2025
Merged
HPCesia
added a commit
to HPCesia/astral-halo
that referenced
this pull request
Apr 5, 2025
- Remove Twikoo's local style. - Remove local package of Artalk and Waline to minify styles This commit is because of unused comment styles in build packaged css. vitejs/vite#19418 might have helped, but Astro didn't use this experimental feature (withastro/astro#13420).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #13347
Closes #13416
Unfortunately that PR created some unwanted regressions, and I am afraid we need to revert it