Fix get relative locale#13045
Merged
ematipico merged 4 commits intoJan 24, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 867f835 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #13045 will not alter performanceComparing Summary
|
Contributor
Author
|
oops gotta add the changeset |
ematipico
approved these changes
Jan 23, 2025
ematipico
left a comment
Member
There was a problem hiding this comment.
Happy to merge once the changeset is ready :)
ematipico
reviewed
Jan 24, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
fixes #13035
getLocaleRelativeUrlwill now return a '/' instead of an empty string in the case ofbase: '/'andtrailingSlash: 'never'.Changing this behavior of
getLocalRelativeUrlcaused a similar error ingetLocaleAbsoluteUrlfortrailingSlash: 'never'because it internaly usesgetLocaleRelativeUrl. This is resolved similarly.Testing
Added tests for both cases - the logic for testing
base: '/'had only been testing whentrailingSlash:'always'.Docs