Actions: expand isInputError to accept unknown#11439
Merged
bholmesdev merged 7 commits intomainfrom Jul 9, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: ddf1bb0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matthewp
approved these changes
Jul 9, 2024
Contributor
matthewp
left a comment
There was a problem hiding this comment.
lgtm. It can also be nice to still put these in define/it blocks so you can have multiple tests in the same file. Even though it can feel a little weird given that the code doesn't run, it can be nice for organization
Contributor
Author
|
@matthewp Yeah, I wasn't sure if that would be misleading for new contributors given the tests don't run? I agree the comment separation isn't great. I'll try that since it sounds like you'd prefer it |
matthewp
previously requested changes
Jul 9, 2024
Merged
ematipico
pushed a commit
that referenced
this pull request
Jul 18, 2024
* feat: allow type `unknown` on `isInputError` * chore: move ErrorInferenceObject to internal utils * chore: changeset * deps: expect-type * feat: first types test * chore: add types test to general test command * refactor: use describe and it for organization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Expand
isInputErrorto acceptunknownas a type, so it can narrow any error object to anActionInputError. This is per feedback in the RFC.unknownErrorInferenceObject. The reason for this utility type was unclear originallyTesting
Manually tested that
isInputErrorstill type narrows and preserves theerror.fieldstypes