Skip to content

feat: 500.astro improvements#11134

Merged
matthewp merged 19 commits intomainfrom
feat/better-error-handling
Jun 19, 2024
Merged

feat: 500.astro improvements#11134
matthewp merged 19 commits intomainfrom
feat/better-error-handling

Conversation

@florian-lefebvre
Copy link
Copy Markdown
Member

@florian-lefebvre florian-lefebvre commented May 23, 2024 •
edited
Loading

Changes

Testing

Adds tests to check:

  1. If the custom 500.astro is rendered in dev/preview
  2. If the default error page (error overlay in dev, nothing in preview) is rendered if the custom 500 throws

Docs

withastro/docs#8392

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 23, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: b4cceb0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added pkg: example Related to an example package (scope) pkg: astro Related to the core `astro` package (scope) labels May 23, 2024
@github-actions github-actions Bot removed the pkg: example Related to an example package (scope) label May 24, 2024
@florian-lefebvre florian-lefebvre changed the title feat: better error handling feat: 500.astro improvements May 24, 2024
@github-actions github-actions Bot added the semver: minor Change triggers a `minor` release label May 24, 2024
github-actions[bot]
github-actions Bot previously requested changes May 24, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@florian-lefebvre florian-lefebvre mentioned this pull request May 24, 2024
Merged
@florian-lefebvre florian-lefebvre marked this pull request as ready for review May 24, 2024 11:29
ematipico
ematipico approved these changes Jun 10, 2024
View reviewed changes
Comment thread packages/astro/src/core/render-context.ts Outdated
Comment thread packages/astro/src/core/app/index.ts
Comment thread .changeset/rich-dolls-compete.md Outdated
Comment thread .changeset/rich-dolls-compete.md Outdated
@ematipico ematipico added this to the 4.11.0 milestone Jun 10, 2024
ematipico
ematipico approved these changes Jun 11, 2024
View reviewed changes
Comment thread packages/astro/test/custom-500.test.js Outdated
Comment thread packages/astro/src/core/app/index.ts
@florian-lefebvre @ematipico
Update packages/astro/test/custom-500.test.js
a888520 
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
sarah11918
sarah11918 reviewed Jun 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick suggestions for your consideration here, @florian-lefebvre ! See what you think, and adjust any of them as necessary.

Comment thread .changeset/rich-dolls-compete.md Outdated
Comment thread .changeset/rich-dolls-compete.md Outdated
Comment thread .changeset/rich-dolls-compete.md Outdated
@florian-lefebvre @sarah11918
Apply suggestions from code review
9c4681c 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
sarah11918
sarah11918 approved these changes Jun 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for docs!! 🥳

bluwy
bluwy reviewed Jun 14, 2024
View reviewed changes
Comment thread .changeset/rich-dolls-compete.md
Comment thread .changeset/rich-dolls-compete.md Outdated
@matthewp matthewp merged commit 9042be0 into main Jun 19, 2024
@matthewp matthewp deleted the feat/better-error-handling branch June 19, 2024 14:00
@astrobot-houston astrobot-houston mentioned this pull request Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

@sarah11918 sarah11918 sarah11918 approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

+1 more reviewer

@bluwy bluwy bluwy left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pkg: astro Related to the core `astro` package (scope) semver: minor Change triggers a `minor` release

Projects

None yet

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

5 participants

@florian-lefebvre @ematipico @sarah11918 @bluwy @matthewp