Merged
Conversation
🦋 Changeset detectedLatest commit: b4cceb0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ematipico
approved these changes
Jun 10, 2024
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
ematipico
approved these changes
Jun 11, 2024
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
sarah11918
reviewed
Jun 11, 2024
Member
sarah11918
left a comment
There was a problem hiding this comment.
Quick suggestions for your consideration here, @florian-lefebvre ! See what you think, and adjust any of them as necessary.
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
bluwy
reviewed
Jun 14, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
500.astropropsASTRO_CUSTOM_500env var is set to'true'Testing
Adds tests to check:
Docs
withastro/docs#8392