Merged
Conversation
wireproxy needs very little permissions, we can restrict it to basically nothing. DynamicUser means the system will generate a UID on demand for service, also CAP_NET_BIND_SERVICE can be used to allow this user to bind to a port < 1024 if desired. Also LoadCredential lets us read a file with tight permissions i.e. root:root 0400 and pass it to only wireproxy in an ephemeral and constrained manner. Signed-off-by: J. Dekker <jdek@itanimul.li>
|
This is interesting, for OpenBSD wireproxy would automatically use |
Contributor
|
Thanks for these improvements! I'm not a pro with systemd units so I'm glad someone took a look |
Choraden
added a commit
to saucelabs/forwarder
that referenced
this pull request
Apr 8, 2024
Forwarder does not need that many permissions, we can restrict it to minimum. CAP_NET_BIND_SERVICE can be used to allow this user to bind to a port < 1024 if desired. The work is based on wireproxy's systemd configuration[1]. Also I found systemd service hardening doc[2] helpful. DynamicUser/Strict system protection didn't work as package installs forwarder binary at /usr/bin. [1] windtf/wireproxy#103. [2] https://gist.github.com/ageis/f5595e59b1cddb1513d1b425a323db04
Choraden
added a commit
to saucelabs/forwarder
that referenced
this pull request
Apr 8, 2024
Forwarder does not need that many permissions, we can restrict it to minimum. CAP_NET_BIND_SERVICE can be used to allow this user to bind to a port < 1024 if desired. The work is based on wireproxy's systemd configuration[1]. Also I found systemd service hardening doc[2] helpful. DynamicUser/Strict system protection didn't work as package installs forwarder binary at /usr/bin. [1] windtf/wireproxy#103. [2] https://gist.github.com/ageis/f5595e59b1cddb1513d1b425a323db04
mmatczuk
pushed a commit
to saucelabs/forwarder
that referenced
this pull request
Apr 8, 2024
Forwarder does not need that many permissions, we can restrict it to minimum. CAP_NET_BIND_SERVICE can be used to allow this user to bind to a port < 1024 if desired. The work is based on wireproxy's systemd configuration[1]. Also I found systemd service hardening doc[2] helpful. DynamicUser/Strict system protection didn't work as package installs forwarder binary at /usr/bin. [1] windtf/wireproxy#103. [2] https://gist.github.com/ageis/f5595e59b1cddb1513d1b425a323db04
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wireproxy needs very little permissions, we can restrict it to basically nothing.
DynamicUsermeans the system will generate a UID on demand for service, alsoCAP_NET_BIND_SERVICEcan be used to allow this user to bind to a port < 1024 if desired.LoadCredentiallets us read a file with tight permissions i.e.root:root 0400and pass it to only wireproxy in an ephemeral and constrained manner.