Skip to content

fix: bind MySQL table listing to configured database name#9007

Merged
rubenfiszel merged 3 commits into
windmill-labs:mainfrom
aayushbaluni:fix/8938-mysql-database-name
May 4, 2026
Merged

fix: bind MySQL table listing to configured database name#9007
rubenfiszel merged 3 commits into
windmill-labs:mainfrom
aayushbaluni:fix/8938-mysql-database-name

Conversation

@aayushbaluni

@aayushbaluni aayushbaluni commented May 2, 2026

Copy link
Copy Markdown
Contributor

Problem

MySQL resource table listing in the Manage view ignores the database name configured in the resource, showing tables from the wrong database or all databases.

Change

Bind the metadata query to the configured database name from the resource, falling back to DATABASE() when no explicit name is given.

Fixes #8938.

Made with Cursor


Summary by cubic

Fixes MySQL table listing to honor the resource’s databaseName; falls back to the session DB when unset. Unifies schema selection for all-table and single-table queries.

  • Bug Fixes
    • Bind TABLE_SCHEMA to databaseName; otherwise use DATABASE() in both query paths.
    • Exclude system schemas; add tests for session fallback and explicit databaseName.

Written for commit 0daadb8. Summary will update on new commits.

@github-actions

github-actions Bot commented May 2, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@aayushbaluni

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request May 2, 2026
rubenfiszel and others added 2 commits May 3, 2026 07:38
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@rubenfiszel rubenfiszel merged commit 44fad13 into windmill-labs:main May 4, 2026
2 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: MySQL resource ignore database name and get the incorrect database

2 participants