feat(mpris): implement bidirectional MPRIS media player support on Linux#20
Merged
flexiondotorg merged 1 commit intomainfrom Mar 22, 2026
Merged
feat(mpris): implement bidirectional MPRIS media player support on Linux#20flexiondotorg merged 1 commit intomainfrom
flexiondotorg merged 1 commit intomainfrom
Conversation
- Create org.mpris.MediaPlayer2 D-Bus service with full interface support - Handle all playback state, metadata, and control methods via dbus-next - Implement volume sync with suppression flag to prevent feedback loops - Add seek detection to emit Seeked signal on user-initiated seeks - Support repeat/shuffle mode mapping between MusicKit and MPRIS - Add Linux-only platform guard and graceful lifecycle management - Include config getter/setter and system tray toggle for enable/disable - Fix BigInt conversion in Seek and SetPosition methods for int64 parameters Allows Linux desktop environments, playerctl, and KDE Connect to control Sidra playback and access track metadata via the MPRIS standard. Signed-off-by: Martin Wimpress <code@wimpress.io>
Contributor
There was a problem hiding this comment.
1 issue found across 9 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/integrations/mpris/index.ts">
<violation number="1" location="src/integrations/mpris/index.ts:568">
P2: Playback state mapping is incorrect: MusicKit `state === 4` (stopped) is being reported as `Paused` instead of `Stopped`.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
org.mpris.MediaPlayer2D-Bus service with full interface supportRef:
Additional Context
Allows Linux desktop environments, playerctl, and KDE Connect to control Sidra playback and access track metadata via the MPRIS standard.
Checklist