Support of Template-level manifest params#33
Open
anibalsanchez wants to merge 16 commits intowilsonge:pwafrom
anibalsanchez:patch-2
Open
Support of Template-level manifest params#33anibalsanchez wants to merge 16 commits intowilsonge:pwafrom anibalsanchez:patch-2
anibalsanchez wants to merge 16 commits intowilsonge:pwafrom
anibalsanchez:patch-2
Conversation
Hi, I've added the support of manifest params at the template level. I would suggest renaming the params in a way that don't generate conflicts with the current template params. Please, check my extension for PWA [Workbox for Joomla - manifest params](https://github.com/anibalsanchez/workboxforjoomla/blob/master/templates/plugins/system/plg_system_workboxforjoomla/workboxforjoomla.xml#L39) where I have prefixed all params with manifest_*
laoneo
pushed a commit
that referenced
this pull request
May 18, 2018
transform admin-multilangstatus.js to es6
cf5aeb7 to
bc2c458
Compare
wilsonge
pushed a commit
that referenced
this pull request
Sep 10, 2018
* Remove ACL check, this will be done in controllers * Add frontend form for confirming information requests * Handle confirming an information request * Use renderField * Add view for submitting info requests for authenticated frontend users * Add menu items for the component frontend views
wilsonge
pushed a commit
that referenced
this pull request
Aug 31, 2019
- disabled buttons with low opacity in the header - issue #33 - center the icons in the header
wilsonge
pushed a commit
that referenced
this pull request
Aug 31, 2019
Fixing Duplicate Image Issue
wilsonge
pushed a commit
that referenced
this pull request
Sep 25, 2019
Remove obsolete columns from SQL statements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've added the support of manifest params at the template level. I would suggest renaming the params in a way that don't generate conflicts with the current template params.
Please, check my extension for PWA Workbox for Joomla - manifest params where I have prefixed all params with manifest_*