Conversation
iliabylich
left a comment
There was a problem hiding this comment.
Thanks! I've left a few comments.
Also there are two missing pieces:
parse_helper.rb,ALL_VERSIONSconstants should include3.3parse_helper.rb,parser_for_ruby_versionmethod needs to handle3.3
|
Thanks for the extremely quick feedback, @iliabylich. I've applied the suggested changes, except the one about the |
|
Thanks! |
|
👋 @iliabylich can I ask when this change is going to be scheduled to be released as a patch version for the gem? 🙇 |
|
I don't plan to release until Ruby 3.2.1 (i.e. with release of the next Ruby version) or in case of a bugfix (that would be Why do you need this change? |
|
We have a running branch every week to test Ruby and the sha that we are targeting is 9726736006b3f74635fd8af05814fe0908e2cf84 which contains this change for the versions It looks like there are other gems like |
Parser gem has been started development for Ruby 3.3 (edge Ruby). whitequark/parser#904 And this PR update to require Parser 3.2.1.0 or higher, which contains `Parser::Ruby33`. https://github.com/whitequark/parser/blob/master/CHANGELOG.md#v3210-2023-02-09
Parser gem has been started development for Ruby 3.3 (edge Ruby). whitequark/parser#904 And this PR update to require Parser 3.2.1.0 or higher, which contains `Parser::Ruby33`. https://github.com/whitequark/parser/blob/master/CHANGELOG.md#v3210-2023-02-09
I've basically mimicked #841.
lib/parser/ruby32.ytolib/parser/ruby33.y, editing the version number on the first line. Since Ruby 3.2 was released a couple of weeks ago, the grammars are probably identical for now (?).lib/parser/version.rb, as I suppose this will be part of the actual release process. Also, since I do not know when the version will be released, I haven't added a timestamp in the changelog.