Test that TransformStream does not use global constructors#852
Merged
ricea merged 2 commits intowhatwg:masterfrom Nov 6, 2017
Merged
Conversation
The TransformStream constructor constructs a ReadableStream and WritableStream. It should use the original constructors rather than what currently exists on the global object. Add tests to verify that it does. Related to issue whatwg#850.
Collaborator
Author
|
I can move this to w3c if #851 happens first. |
domenic
approved these changes
Nov 2, 2017
| assert_not_equals(getWriter.call(ts.writable), undefined, | ||
| 'getWriter should work when called on ts.writable'); | ||
|
|
||
| ReadableStream = oldReadableStream; |
Member
There was a problem hiding this comment.
These should probably be in a t.cleanup(() => { ... }) at the top, just to be safe.
Collaborator
Author
There was a problem hiding this comment.
That's better, thanks.
ricea
added a commit
to ricea/web-platform-tests
that referenced
this pull request
Nov 7, 2017
The test added in whatwg/streams#852 was missing from the previous commit. Add it.
ricea
added a commit
to ricea/web-platform-tests
that referenced
this pull request
Nov 9, 2017
The test added in whatwg/streams#852 was missing from the previous commit. Add it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TransformStream constructor constructs a ReadableStream and
WritableStream. It should use the original constructors rather than what
currently exists on the global object.
Add tests to verify that it does.
Related to issue #850.