Skip to content

Make togglePopover throw more exceptions#9451

Merged
annevk merged 2 commits into
whatwg:mainfrom
josepharhar:togglethrow
Jun 28, 2023
Merged

Make togglePopover throw more exceptions#9451
annevk merged 2 commits into
whatwg:mainfrom
josepharhar:togglethrow

Conversation

@josepharhar

@josepharhar josepharhar commented Jun 21, 2023 •
edited by pr-preview Bot
Loading

Copy link
Copy Markdown
Contributor

This PR makes sure that togglePopover will throw exceptions when it is disconnected from the document or doesn't have a popover attribute.

Fixes #8999

(See WHATWG Working Mode: Changes for more details.)

/popover.html ( diff )

@josepharhar
Make togglePopover throw more exceptions
032125c 
This PR makes sure that togglePopover will throw exceptions when it is
disconnected from the document or doesn't have a popover attribute.

Fixes whatwg#8999
@josepharhar josepharhar mentioned this pull request Jun 21, 2023
Closed
@nt1m nt1m requested a review from annevk June 24, 2023 05:32
@nt1m

nt1m commented Jun 24, 2023

Copy link
Copy Markdown
Member

Looks ok to me, @annevk what do you think?

@nt1m nt1m added the topic: popover The popover attribute and friends label Jun 24, 2023
annevk
annevk approved these changes Jun 28, 2023
View reviewed changes

@annevk annevk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable and thanks for addressing! Please complete the checkboxes in OP and address the nit.

Comment thread source Outdated
@nt1m

nt1m commented Jun 28, 2023

Copy link
Copy Markdown
Member

(there's already a WebKit bug so no need to file one: https://bugs.webkit.org/show_bug.cgi?id=258574)

@josepharhar

josepharhar commented Jun 28, 2023

Copy link
Copy Markdown
Contributor Author

Please complete the checkboxes in OP and address the nit.

done

@annevk annevk merged commit be5c890 into whatwg:main Jun 28, 2023
@josepharhar josepharhar mentioned this pull request Jun 29, 2023
Merged
4 tasks
@YusukeHirao YusukeHirao mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annevk annevk annevk approved these changes

Assignees

No one assigned

Labels

topic: popover The popover attribute and friends

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

togglePopover() algorithm does not check popover validity when force == false and when the popover visibility state is hidden

3 participants

@josepharhar @nt1m @annevk