Make togglePopover throw more exceptions#40682
Merged
Merged
Conversation
wpt-pr-bot
approved these changes
Jun 21, 2023
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
4 tasks
cd20864 to
efc1cb3
Compare
This patch makes sure that togglePopover will throw exceptions when it is disconnected from the document or doesn't have a popover attribute. This is being discussed here: whatwg/html#8999 Change-Id: Iac7a486cd64b09b5657a157dbf3e9e54c1be2a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4634324 Auto-Submit: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1166059}
efc1cb3 to
64cc2e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch makes sure that togglePopover will throw exceptions when it
is disconnected from the document or doesn't have a popover attribute.
This is being discussed here: whatwg/html#8999
Change-Id: Iac7a486cd64b09b5657a157dbf3e9e54c1be2a27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4634324
Auto-Submit: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1166059}