Skip to content

Remove the notion of "secured plugins"#6946

Merged
annevk merged 1 commit intomainfrom
no-secure-plugins
Aug 30, 2021
Merged

Remove the notion of "secured plugins"#6946
annevk merged 1 commit intomainfrom
no-secure-plugins

Conversation

@domenic
Copy link
Member

@domenic domenic commented Aug 9, 2021

Instead, sandboxed iframes are just never allowed to display plugins. (Which, in the modern world, just means PDFs.)

Closes #3958. Helps with #6003.

(See WHATWG Working Mode: Changes for more details.)


/browsing-the-web.html ( diff )
/iframe-embed-object.html ( diff )
/infrastructure.html ( diff )
/origin.html ( diff )

Instead, sandboxed iframes are just never allowed to display plugins. (Which, in the modern world, just means PDFs.)

Closes #3958. Helps with #6003.
@domenic domenic added removal/deprecation Removing or deprecating a feature topic: embed and object labels Aug 9, 2021
@domenic
Copy link
Member Author

domenic commented Aug 9, 2021

I found the issue with http://wpt.live/html/semantics/embedded-content/the-iframe-element/sandbox_004-manual.htm; it was missing a Content-Type header. (Which is good news as it implies only Firefox looks at the file extension!)

I've updated the OP to reflect the results of the testing.

domenic added a commit to web-platform-tests/wpt that referenced this pull request Aug 9, 2021
@annevk
Copy link
Member

annevk commented Aug 10, 2021

Yeah, this seems fine. It would be great if @mikewest could double check this as he got it added at some point in the past, I think.

@domenic
Copy link
Member Author

domenic commented Aug 10, 2021

Mike's OOO until the 16th, but I guess there's no rush. Setting a reminder to ping him next week.

@mikewest
Copy link
Member

Mike's OOO until the 16th, but I guess there's no rush. Setting a reminder to ping him next week.

Mike's working his way through his inbox. :)

Practically, we aren't implementing a "secured plugin" concept in Chromium yet, so removing it from the spec is reasonable. Philosophically, PDFium being implemented as a plugin in Chromium is an implementation detail that's somewhat unfortunate from a spec perspective. On the one hand, I don't want HTML to turn into a PDF-rendering spec. On the other, I think it would be quite useful for us to be able to interoperably render PDFs in a sandbox, and we're becoming more capable of doing so as PDFium is growing more integration points to other bits and pieces of Chromium.

So, maybe this concept can come back at some point? I think this more or less matches what @annevk suggested in #3958 (comment).

@domenic
Copy link
Member Author

domenic commented Aug 16, 2021

Yeah, that makes sense to me. Overall the goal is to move toward a world where "plugins" as a concept no longer exists, but "PDF viewer documents" do. (Preferably with an opaque origin; see #6947.) Then in the future if all browsers feel that it's safe to embed PDF documents inside sandboxed iframes, we can just remove the prohibition on them. (And also remove the allow-plugins keyword since it will no longer have any effect.)

@domenic domenic requested a review from annevk August 17, 2021 18:47
@annevk annevk merged commit c2bcadd into main Aug 30, 2021
@annevk annevk deleted the no-secure-plugins branch August 30, 2021 13:14
annevk pushed a commit to web-platform-tests/wpt that referenced this pull request Sep 3, 2021
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Sep 22, 2021
… test, a=testonly

Automatic update from web-platform-tests
Fix and make automatic sandboxed plugins test

Follows whatwg/html#6946.

--

wpt-commits: 789f310832f7746b34bdc6afa16ff1e1a7a8f4af
wpt-pr: 29951
aosmond pushed a commit to aosmond/gecko that referenced this pull request Sep 24, 2021
… test, a=testonly

Automatic update from web-platform-tests
Fix and make automatic sandboxed plugins test

Follows whatwg/html#6946.

--

wpt-commits: 789f310832f7746b34bdc6afa16ff1e1a7a8f4af
wpt-pr: 29951
jwidar pushed a commit to jwidar/LatencyZeroGithub that referenced this pull request Sep 16, 2025
… test, a=testonly

Automatic update from web-platform-tests
Fix and make automatic sandboxed plugins test

Follows whatwg/html#6946.

--

wpt-commits: 789f310832f7746b34bdc6afa16ff1e1a7a8f4af
wpt-pr: 29951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

removal/deprecation Removing or deprecating a feature topic: embed and object

Development

Successfully merging this pull request may close these issues.

Interop: pdf might or might not render in a sandboxed iframe (depending on a browser)

3 participants