Add ElementInternals.shadowRoot#5912
Merged
domenic merged 7 commits intowhatwg:masterfrom Oct 5, 2020
Merged
Conversation
This was referenced Sep 14, 2020
rniwa
suggested changes
Sep 16, 2020
f297ce6 to
8457fc3
Compare
Collaborator
Author
|
Ok, I think comments are addressed here. |
pull bot
pushed a commit
to Mu-L/chromium
that referenced
this pull request
Sep 26, 2020
Per some recent spec discussions/changes, declarative shadow roots should manually set the "available to element internals" flag, rather than assuming that in the check. See [1]. [1] whatwg/html#5912 (comment) Bug: 1042130 Change-Id: If50fa8bff4cddb566edf95cbd1b1a8f1afe11b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429852 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#810930}
domenic
requested changes
Sep 28, 2020
64953de to
40ae5a2
Compare
Collaborator
Author
|
Alright, thanks for the review. I think I addressed all of the comments. |
domenic
pushed a commit
to whatwg/dom
that referenced
this pull request
Oct 5, 2020
This is for use with whatwg/html#5912, which restricts access to ElementInternals's shadowRoot property for shadow roots which were pre-existing before a custom element upgrade/construction. See the discussion in WICG/webcomponents#871 (comment) for more context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to retrieve the shadow root from
ElementInternals, via theElementInternals.shadowRootattribute. This attribute is restricted to only return shadow roots created during or after the custom element constructor, for custom elements.See the discussion on Issue 871 for more context. There is a corresponding DOM spec PR also.
💥 Error: Wattsi server error 💥
PR Preview failed to build. (Last tried on Sep 16, 2020, 4:39 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.