Depend on Fullscreen API's removing steps when <dialog> is removed#3064
Depend on Fullscreen API's removing steps when <dialog> is removed#3064foolip wants to merge 1 commit into
Conversation
| document</span>'s <span>top layer</span>.</p> | ||
|
|
||
| <p class="note">If <var>subject</var> is <span data-x="node is removed from a document">removed | ||
| from its document</span> while still in the <span>top layer</span>, then the <a>removing |
There was a problem hiding this comment.
@annevk, I'm not too happy about this and want to export "fullscreen removing steps" or "top layer removing steps" in Fullscreen. But I'm not sure how to phrase it so that's it's clear that it's an instance of "removing steps" in HTML. Ideas?
There was a problem hiding this comment.
Why not rename it in Fullscreen too? Or do I misunderstand?
There was a problem hiding this comment.
The trouble is that https://dom.spec.whatwg.org/#concept-node-remove-ext says "Specifications may define removing steps for all or some nodes." and Fullscreen refers to that, but because of this there's no concept in Fullscreen itself that I could link to here.
There was a problem hiding this comment.
I see. Add an id in Fullscreen and use that here for a direct link? And note in Fullscreen that HTML uses that ID?
|
OK, this and whatwg/fullscreen#102 are now ready to go. |
|
Seems like whatwg/fullscreen#102 needs to land first. |
|
What's still blocking is getting web-platform-tests/wpt#6302 in order. |
92249d7 to
95d59bf
Compare
Also test that dialog.remove() doesn't do any of the things one might reasonably expect, to match the current spec and what's implemented. Tests for: whatwg/fullscreen#102 whatwg/html#3064
Also test that dialog.remove() doesn't do any of the things one might reasonably expect, to match the current spec and what's implemented. Tests for: whatwg/fullscreen#102 whatwg/html#3064 Drive-by: t.add_cleanup(() => document.exitFullscreen())
Also test that dialog.remove() doesn't do any of the things one might reasonably expect, to match the current spec and what's implemented. Tests for: whatwg/fullscreen#102 whatwg/html#3064 Drive-by: t.add_cleanup(() => document.exitFullscreen())
|
It seems that since whatwg/fullscreen#128 ended up being it on the Fullscreen side, the |
|
Yes, closing... |
Part of whatwg/fullscreen#102.
💥 Error: Wattsi server error 💥
PR Preview failed to build. (Last tried on Jan 15, 2021, 7:58 AM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Wattsi Server - Wattsi Server is the web service used to build the WHATWG HTML spec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.