Link to "run the fullscreen rendering steps" in Fullscreen#2763
Conversation
|
@zcorpan, PTAL? "rendering steps" is a bit of a misnomer as it only fires events, if you have a better name I'll take it. |
c503df8 to
ca65ca4
Compare
zcorpan
left a comment
There was a problem hiding this comment.
LGTM. No strong opinion about the name of the hook, but agree that "rendering steps" seems a bit weird.
|
How about just "run the fullscreen steps"? Or "run the fullscreen animation frame steps"? |
|
run the fullscreen steps SGTM. |
|
In CSSOM View I say "This section integrates with the event loop defined in HTML. [HTML]" before the relevant algorithm to clarify what it's for. |
Matches whatwg/fullscreen#94. Fixes the fullscreen part of #707. Drive-by: re-wrap lines to 100 columns.
ca65ca4 to
c1b088a
Compare
|
Renamed in whatwg/fullscreen#94 and updated this to match, LGTY? |
|
Didn't add "Editorial:" to this one since it actually adds a real code path to HTML instead of calling into the void. |
|
The fullscreen PR was reviewed and merged, so I'll just go ahead with this, just a trivial rename since review. |
Introduced in whatwg/fullscreen#92.
Fixes the fullscreen part of #707.
Drive-by: re-wrap lines to 100 columns.